Skip to content

Conversation

@zth
Copy link
Member

@zth zth commented May 16, 2022

cc @ryyppy @cristianoc

Very open to feedback here. I wanted to add these two to the official documentation (even though they're strictly from reanalyze) because I'm using them quite a lot in my code bases, and I've noticed people try to look them up, but struggling to find them. I personally thing reanalyze is so good we should push it more, therefore adding these here.

@ryyppy
Copy link
Member

ryyppy commented May 23, 2022

If we add those, we should add a proper markdown note component saying This decorator requires reanalyze to be installed, with a link to the installation instructions.

Even if examples don't make too much sense, it would still be nice to have some code snippet showing how the decorator may be applied.

But I agree, the decorator may be part of the platform at some point, so might as well add it with the extra note on the installation.

@zth
Copy link
Member Author

zth commented May 23, 2022

@ryyppy sounds good, will fix tomorrow.

@zth
Copy link
Member Author

zth commented May 28, 2022

@ryyppy mind taking another look?

@zth zth changed the title add @live and @dead attributes to syntax lookup add @live/@dead/@raises/@doesNotRaise decorators from reanalyze to syntax lookup May 28, 2022
@ryyppy ryyppy merged commit 6eb9a69 into rescript-lang:master Jul 29, 2022
@ryyppy
Copy link
Member

ryyppy commented Jul 29, 2022

thanks!

@zth zth deleted the add-live-dead-attributes branch July 29, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants